notfilippo commented on code in PR #165:
URL: https://github.com/apache/datasketches-rust/pull/165#discussion_r3658792109
##########
datasketches/src/hll/mod.rs:
##########
@@ -209,14 +209,14 @@ impl Coupon {
/// You may use [`hash_value`](crate::hash_value) wrappers when matching
other datasketches
/// implementations require a specific value hashing strategy.
///
- /// Hashes `v` using MurmurHash3 128-bit and packs the result into a
coupon:
+ /// Hashes `value` using MurmurHash3 128-bit and packs the result into a
coupon:
/// the low 26 bits of the low hash word become the slot index, and the
/// leading-zero count of the high hash word (capped at 62, then plus one)
/// becomes the 6-bit register value.
#[inline(always)]
- pub fn from_hash<T: Hash>(v: T) -> Self {
+ pub fn from_value<T: Hash>(value: T) -> Self {
Review Comment:
Much clearer. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
