hawkingrei commented on PR #142: URL: https://github.com/apache/datasketches-rust/pull/142#issuecomment-5151148145
@ZENOTME Implemented your shared raw-layer direction in `419be13`. `RawThetaJaccardSimilarity` is now in `thetacommon` and generic over `ThetaFamilySketchView`; the Theta API is only a thin wrapper. The raw implementation composes the existing shared `UnionState` and `IntersectionState`, matching the C++ `jaccard_similarity_base` structure rather than maintaining independent set-operation logic. This makes the common layer ready for Tuple reuse when its public Jaccard API is added, without expanding this PR beyond Theta. Could you please review the updated structure? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
