pmcgleenon opened a new pull request, #204: URL: https://github.com/apache/datasketches-rust/pull/204
This is a port of [reqsketch-rs](https://github.com/pmcgleenon/reqsketch-rs) as discussed here https://github.com/apache/datasketches-rust/issues/90. This implementation is influenced heavily by the apache datasketches C++ implementation. Some things present in reqsketch-rs that are not part of this PR: - [benchmarks](https://github.com/pmcgleenon/reqsketch-rs/blob/main/benches/core_benchmarks.rs), I left these out since I didn't see any other benchmarks. Maybe we can add some in a later PR for all the sketches - program build the plots [rank error plots](https://github.com/pmcgleenon/reqsketch-rs/blob/main/examples/req_rank_error.rs). There are a bunch of dependencies needed for this so I left it out. But I think it's a great visualization of the reqsketch algorithm and helps with validation of the results since the apache-datasketches project [has similar plots](https://datasketches.apache.org/docs/REQ/ReqSketch.html) and they can be easily compared to validate the results @tisonkun FYI if you get a chance please take a look -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
