Pierre-Arnaud Marcelot schrieb: > Hi Alex, > > I also noticed this. > > I don't trust the RAT plugin. I only use it to generate the report and > then verify by hand the files. > I think the decision of releasing something should not be based on the > number or "wrong" files this plugin indicates... > In fact target directory should be excluded by RTFM: http://mojo.codehaus.org/rat-maven-plugin/check-mojo.html (useMavenDefaultExcludes <http://mojo.codehaus.org/rat-maven-plugin/check-mojo.html#useMavenDefaultExcludes>) or I get something wrong.*
* > Regards, > Pierre-Arnaud > > On Wed, Sep 3, 2008 at 5:13 PM, Alex Karasulu <[EMAIL PROTECTED] > <mailto:[EMAIL PROTECTED]>> wrote: > > On Wed, Sep 3, 2008 at 11:05 AM, Felix Knecht <[EMAIL PROTECTED] > <mailto:[EMAIL PROTECTED]>> wrote: > > > > > > Yes I think we already do this for ApacheDS project when the > -Prelease > > flag is present to trigger the release profile. If we do > not then we > > should - we should do what you suggest TLP wide. > > Ok. I added the rat:check to the -Prelease. Please note that > ATM almost > none of the projects can be released because of this. E.g. > apacheds: > > mvn clean install -Prelease > [INFO] Scanning for projects... > [INFO] Reactor build order: > <snip /> > [ERROR] BUILD FAILURE > [INFO] > > ------------------------------------------------------------------------ > [INFO] Too many unapproved licenses: 1625 > > See also the rat reports: > http://vm094.oxylos.org/projects/apacheds/rat-report.html > http://vm094.oxylos.org/projects/daemon/rat-report.html > http://vm094.oxylos.org/projects/shared/rat-report.html > http://vm094.oxylos.org/projects/studio/rat-report.html > http://vm094.oxylos.org/projects/studio-plugin/rat-report.html > > IMO rat cancel the build as long as it finds Unknown licenses. > > Rat reports are only generate for projects using the > project/pom version > 12-SNAPSHOT. > > If we want to go ahead with the release we should update now the > project/pom.xml, release it, set in all sub projects (if > exists) the > parent pom to the relased version (12) and then continue with > fixing > whatever is needed for the release of the subproject. > > > Agreed we should release the project project asap and then focus > on the subprojects as you suggest. > > BTW notice that some of those files that RAT complains about are > build byproducts generated by maven in the target directory. Like > for ApacheDS the unknown licenses for files are things like > surefire reports and maven intermediate files under target. > > I wonder if we can tell RAT to ignore what's under the target > directory. > > Alex > > Alex > >
