bdemers commented on code in PR #79:
URL: https://github.com/apache/directory-ldap-api/pull/79#discussion_r1498524948
##########
ldap/client/api/src/main/java/org/apache/directory/ldap/client/api/LdapConnectionPool.java:
##########
@@ -123,6 +123,10 @@ public LdapConnection getConnection() throws LdapException
try
{
connection = super.borrowObject();
+ if ( connection instanceof PooledLdapConnection )
+ {
+ ( ( PooledLdapConnection ) connection ).setConnectionPool(
this );
+ }
Review Comment:
After writing this down... I kind of like the other option better,
configuration happens once in the constructor.
https://github.com/apache/directory-ldap-api/pull/80/files#diff-b8123224665e83d673c7d58020ec9dcaa4f1761291ff7c06309d1af591ea5f2aR100-R103
That said, I don't know how often folks extend these classes, though I'd
guess most folks would extend `AbstractPoolableLdapConnectionFactory` if
needed, so #80 _should_ work in most cases.
@elecharny thoughts on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
