bdemers commented on PR #541: URL: https://github.com/apache/directory-scimple/pull/541#issuecomment-1997604195
@symphony-enrico SCIMple's ETag support is an area that I think could be improved. (and this Pull Request is very. appreciated in moving that forward!!) SCIMple _basically_ has 2 types of resources: - In Memory (Schema, Configuration, these are created when the application starts, and _likely_ will not change) - Repository controlled (e.g. the persistence of `ScimUser`/`ScimGroup`) For the in memory items, the `ETagGenerator` should be used. For Repository controlled objects, it's up to the implementation, they can use the `ETagGenerator`, but they could also use something else (e.g. functionality tied to a database) > [!NOTE] > This was relatively recent change (before the last release). For implementations that don't return all fields based on optimized lookups based on the [`attributes`/`excludedAttributes` params](https://datatracker.ietf.org/doc/html/rfc7644#section-3.4.2.5) using the `ETagGenerator` would have resulted in an _incorrect_ version/etag. For example, if a ScimUser Repository that did NOT return group memberships, that data would be missing for hashing in the `ETagGenerator`. All that being said, if you have thoughts around this, ways to make this easier, or think my above assumption is wrong. Please let us know! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
