Hi Maxime and David, I see patch " vhost: fix offload flags in Rx path " http://patches.dpdk.org/project/dpdk/patch/[email protected]/ has been merged, and the legacy implementation is kept. Do you think we still need to fix the header check for the legacy implementation?
BRs, Xiao > -----Original Message----- > From: Maxime Coquelin <[email protected]> > Sent: Tuesday, April 13, 2021 10:31 PM > To: David Marchand <[email protected]>; Wang, Xiao W > <[email protected]> > Cc: Xia, Chenbo <[email protected]>; Liu, Yong <[email protected]>; > dev <[email protected]>; Ananyev, Konstantin > <[email protected]>; dpdk stable <[email protected]>; > [email protected] > Subject: Re: [PATCH v3] vhost: add header check in dequeue offload > > > > On 4/12/21 11:33 AM, David Marchand wrote: > > On Mon, Apr 12, 2021 at 11:09 AM Wang, Xiao W > <[email protected]> wrote: > >> Considering the major consumer of vhost API is virtual switch/router, I > tend to keep the current implementation and apply this fix patch. > >> Any comments? > > > > This is just a hack that bypasses the vswitch control. > > > > It happens to work when the vswitch does nothing. > > If anything is done, like popping a vlan header, the vswitch needs to > > update l3 offset. > > > > > > I agree with David, current behavior is wrong. > > Furthermore, when the lib is used via the Vhost PMD, the application > should not have to handle it differently on whether it is Vhost PMD or > any physical NIC PMD.
