> -----Original Message----- > From: Bing Zhao <[email protected]> > Sent: Tuesday, November 16, 2021 4:01 PM > To: Xia, Chenbo <[email protected]>; Slava Ovsiienko > <[email protected]>; Matan Azrad <[email protected]>; > [email protected] > Cc: [email protected]; Raslan Darawsheh <[email protected]> > Subject: RE: [PATCH] vdpa/mlx5: fix return value check of mkey create > > Hi Chenbo, > > > > -----Original Message----- > > From: Xia, Chenbo <[email protected]> > > Sent: Tuesday, November 16, 2021 3:54 PM > > To: Bing Zhao <[email protected]>; Slava Ovsiienko > > <[email protected]>; Matan Azrad <[email protected]> > > Cc: [email protected]; Raslan Darawsheh <[email protected]> > > Subject: RE: [PATCH] vdpa/mlx5: fix return value check of mkey > > create > > > > External email: Use caution opening links or attachments > > > > > > > -----Original Message----- > > > From: Bing Zhao <[email protected]> > > > Sent: Friday, November 12, 2021 10:43 PM > > > To: [email protected]; [email protected] > > > Cc: [email protected]; [email protected] > > > Subject: [PATCH] vdpa/mlx5: fix return value check of mkey create > > > > > > The return value of "mlx5_os_wrapped_mkey_create" is checked in > > the > > > caller. A zero means success without any error. > > > > > > The typo in the if-condition should be fixed in case there is a > > > misjudgment. > > > > > > Fixes: f26e06d97d57 ("vdpa/mlx5: workaround dirty bitmap MR > > creation") > > > > Wrong commit id, should be the one in main tree: > > > > Fixes: 398ea8450c53 ("vdpa/mlx5: workaround dirty bitmap MR > > creation") > > > > With this fixed: > > > > Reviewed-by: Chenbo Xia <[email protected]> > > Thanks for the comments. > Is there any need to send a v2 or Maxime will help on this?
I think it can be fixed when applying. Thanks, Chenbo
