Hi,
> -----Original Message-----
> From: Stephen Hemminger <[email protected]>
> Sent: Thursday, February 10, 2022 3:18
> To: [email protected]
> Cc: Stephen Hemminger <[email protected]>; Hemant Agrawal
> <[email protected]>; Jakub Palider <[email protected]>;
> Tomasz Duszynski <[email protected]>; Nipun Gupta
> <[email protected]>; Xu, Rosen <[email protected]>; Zhang, Tianfei
> <[email protected]>
> Subject: [PATCH v3 32/36] raw/*: remove unnecessary NULL checks
>
> Remove redundant NULL pointer checks before free functions found by
> nullfree.cocci
>
> Signed-off-by: Stephen Hemminger <[email protected]>
> Acked-by: Hemant Agrawal <[email protected]>
> ---
> drivers/raw/cnxk_bphy/cnxk_bphy_cgx.c | 3 +--
> drivers/raw/dpaa2_qdma/dpaa2_qdma.c | 15 +++++----------
> drivers/raw/ifpga/ifpga_rawdev.c | 9 +++------
> drivers/raw/skeleton/skeleton_rawdev_test.c | 6 ++----
> 4 files changed, 11 insertions(+), 22 deletions(-)
>
> diff --git a/drivers/raw/ifpga/ifpga_rawdev.c
> b/drivers/raw/ifpga/ifpga_rawdev.c
> index fdf3c23d2c5f..b73512d3ada5 100644
> --- a/drivers/raw/ifpga/ifpga_rawdev.c
> +++ b/drivers/raw/ifpga/ifpga_rawdev.c
> @@ -836,8 +836,7 @@ rte_fpga_do_pr(struct rte_rawdev *rawdev, int
> port_id,
> }
>
> free_buffer:
> - if (buf_to_free)
> - rte_free(buf_to_free);
> + rte_free(buf_to_free);
> close_fd:
> close(file_fd);
> file_fd = 0;
> @@ -1739,10 +1738,8 @@ ifpga_cfg_probe(struct rte_vdev_device *dev)
> ret = rte_eal_hotplug_add(RTE_STR(IFPGA_BUS_NAME),
> dev_name, devargs->args);
> end:
> - if (kvlist)
> - rte_kvargs_free(kvlist);
> - if (name)
> - free(name);
> + rte_kvargs_free(kvlist);
> + free(name);
>
> return ret;
> }
Reviewed-by Rosen Xu <[email protected]>
