> -----Original Message----- > From: Yigit, Ferruh <[email protected]> > Sent: Friday, March 11, 2022 6:47 PM > To: Liu, KevinX <[email protected]>; Zhang, Qi Z <[email protected]>; > dev > <[email protected]>; Thomas Monjalon <[email protected]> > Cc: Yang, Qiming <[email protected]>; Yang, SteveX > <[email protected]>; Xing, Beilei <[email protected]>; Li, Xiaoyun > <[email protected]>; dpdk stable <[email protected]>; Zhang, Yuying > <[email protected]> > Subject: Re: [PATCH v2 2/2] app/testpmd: fix SW L4 checksum in multi-segments > > On 3/11/2022 7:04 AM, Liu, KevinX wrote: > > message moved down, please do not top post > > >> -----Original Message----- > >> From: Zhang, Yuying <[email protected]> > >> Sent: 2022年3月3日 14:30 > >> To: Zhang, Qi Z <[email protected]>; Liu, KevinX > >> <[email protected]>; dev <[email protected]> > >> Cc: Yang, Qiming <[email protected]>; Yang, SteveX > >> <[email protected]>; Yigit, Ferruh <[email protected]>; > >> Xing, Beilei <[email protected]>; Li, Xiaoyun > >> <[email protected]>; dpdk stable <[email protected]> > >> Subject: RE: [PATCH v2 2/2] app/testpmd: fix SW L4 checksum in multi- > >> segments > >> > >> LGTM. > >> > >>>> -----Original Message----- > >>>> From: Liu, KevinX <[email protected]> > >>>> Sent: Wednesday, December 29, 2021 5:37 PM > >>>> To: [email protected] > >>>> Cc: Yang, Qiming <[email protected]>; Zhang, Qi Z > >>>> <[email protected]>; Yang, SteveX <[email protected]>; > >>>> Yigit, Ferruh <[email protected]>; Liu, KevinX > >>>> <[email protected]>; [email protected] > >>>> Subject: [PATCH v2 2/2] app/testpmd: fix SW L4 checksum in > >>>> multi-segments > >>>> > >>>> Testpmd forwards packets in checksum mode that it needs to > >>>> calculate the checksum of each layer's protocol. > >>>> > >>>> In process_inner_cksums, when parsing tunnel packets, inner L4 > >>>> offset should be outer_l2_len + outer_l3_len + l2_len + l3_len. > >>>> > >>>> In process_outer_cksums, when parsing tunnel packets, outer L4 > >>>> offset should be outer_l2_len + outer_l3_len. > >>>> > >>>> Fixes: e6b9d6411e91 ("app/testpmd: add SW L4 checksum in multi- > >>>> segments") > >>>> Cc: [email protected] > >>>> > >>>> Signed-off-by: Kevin Liu <[email protected]> > >> > >> Acked-by: Yuying Zhang <[email protected]> > >> > > Hi, Ferruh > > > > Yuying has already reviewed it days ago. > > If you can, I hope you can change the status as soon as possible and try to > merge the code in RC4. > > Thank you. > > > > +Thomas, he is getting patches for -rc4. > > And just for double check Qi, are you comfortable with patch? > (I am asking because initially this is set with ice and testpmd patch)
Yes, I'm OK with this patch. It has been verified on most of Intel PMDs.
