Re: [PATCH v3] app/testpmd: support ddp dump command for ice

[Andrew Rybchenko]

On 5/18/22 18:24, Stephen Hemminger wrote:
On Wed, 18 May 2022 06:58:06 +0000
Steve Yang <stevex.y...@intel.com> wrote:
+#define ICE_BUFF_SIZE  0x000c9000
Having magic size hard coded in testpmd is bad idea.
If there is driver specific size it should be exposed by API

+       size = ICE_BUFF_SIZE;
+       buff = (uint8_t *)malloc(ICE_BUFF_SIZE);

Cast of void * is not necessary in C (only C++)

Also the patch breaks build as reported by CI [1]:

[1] 
https://patches.dpdk.org/project/dpdk/patch/20220518065806.1005694-1-stevex.y...@intel.com/