Hi Maxime, > -----Original Message----- > From: Xia, Chenbo <[email protected]> > Sent: Friday, June 10, 2022 11:50 AM > To: Maxime Coquelin <[email protected]>; [email protected]; > [email protected]; [email protected]; Matz, Olivier > <[email protected]>; Ma, WenwuX <[email protected]>; Zhang, > Yuying <[email protected]>; Singh, Aman Deep > <[email protected]> > Subject: RE: [PATCH v2 6/6] net/vhost: perform SW checksum in Tx path > > +Cheng for review > > > -----Original Message----- > > From: Maxime Coquelin <[email protected]> > > Sent: Wednesday, June 8, 2022 8:50 PM > > To: [email protected]; [email protected]; Xia, Chenbo > > <[email protected]>; [email protected]; Matz, Olivier > > <[email protected]>; Ma, WenwuX <[email protected]>; > Zhang, > > Yuying <[email protected]>; Singh, Aman Deep > > <[email protected]> > > Cc: Maxime Coquelin <[email protected]> > > Subject: [PATCH v2 6/6] net/vhost: perform SW checksum in Tx path > > > > Virtio specification supports guest checksum offloading for L4, which > > is enabled with VIRTIO_NET_F_GUEST_CSUM feature negotiation. > However, > > the Vhost PMD does not advertise Tx checksum offload capabilities. > > > > Advertising these offload capabilities at the ethdev level is not > > enough, because we could still end-up with the application enabling > > these offloads while the guest not negotiating it. > > > > This patch advertises the Tx checksum offload capabilities, and > > introduces a compatibility layer to cover the case > > VIRTIO_NET_F_GUEST_CSUM has not been negotiated but the application > > does configure the Tx checksum offloads. This function performs the L4 > > Tx checksum in SW for UDP and TCP. > > Compared to Rx SW checksum, the Tx SW checksum function needs to > > compute the pseudo-header checksum, as we cannot know whether it was > > done before. > > > > This patch does not advertise SCTP checksum offloading capability for > > now, but it could be handled later if the need arises. > > > > Reported-by: Jason Wang <[email protected]> > > Signed-off-by: Maxime Coquelin <[email protected]> > > ---
Reviewed-by: Cheng Jiang <[email protected]>
