On Wed, Jun 15, 2022 at 7:32 PM David Marchand <[email protected]> wrote: > > On Tue, Jun 14, 2022 at 8:06 AM Chengwen Feng <[email protected]> wrote: > > > > Bug scenario: > > 1. start testpmd: > > dpdk-testpmd -l 4-6 -a 0000:7d:00.0 --trace=.* \ > > -file-prefix=trace_autotest -- -i > > 2. then observed: > > EAL: eal_trace_init():94 failed to initialize trace [File exists] > > This is not directly related to the issue being fixed, but this error > log is really obscure.. > Can we enhance this, maybe in a followup patch? > > > > EAL: FATAL: Cannot init trace > > EAL: Cannot init trace > > EAL: Error - exiting with code: 1 > > > > The root cause it that the offset set wrong with long file-prefix and > > then lead the strftime return failed. > > > > Fixes: 321dd5f8fa62 ("trace: add internal init and fini interface") > > Cc: [email protected] > > > > Signed-off-by: Chengwen Feng <[email protected]> > > Reviewed-by: David Marchand <[email protected]>
Acked-by: Jerin Jacob <[email protected]>
