On Mon, Jul 4, 2022 at 9:11 AM Yuan Wang <[email protected]> wrote:
>
> The callfds[] array stores eventfds sequentially for Rx and Tx vq.
>
> Fixes: d61138d4f0e2 ("drivers: remove direct access to interrupt handle")
> Cc: [email protected]
>
> Signed-off-by: Yuan Wang <[email protected]>
Good catch...
This is what I had fixed in 848e93d9001e ("net/virtio-user: fix Rx
interrupts with multi-queue").
I suppose the issue has been reintroduced when rebasing Harman series.
> ---
> drivers/net/virtio/virtio_user/virtio_user_dev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.c
> b/drivers/net/virtio/virtio_user/virtio_user_dev.c
> index 35aa76b1ff..f9cada05e4 100644
> --- a/drivers/net/virtio/virtio_user/virtio_user_dev.c
> +++ b/drivers/net/virtio/virtio_user/virtio_user_dev.c
> @@ -417,7 +417,7 @@ virtio_user_fill_intr_handle(struct virtio_user_dev *dev)
>
> for (i = 0; i < dev->max_queue_pairs; ++i) {
> if (rte_intr_efds_index_set(eth_dev->intr_handle, i,
> - dev->callfds[i]))
> + dev->callfds[2 * i + VTNET_SQ_RQ_QUEUE_IDX]))
> return -rte_errno;
> }
Reviewed-by: David Marchand <[email protected]>
--
David Marchand
