> -----Original Message----- > From: Ding, Xuan <[email protected]> > Sent: Thursday, July 7, 2022 2:55 PM > To: [email protected]; Xia, Chenbo <[email protected]> > Cc: [email protected]; Hu, Jiayu <[email protected]>; He, Xingguang > <[email protected]>; Yang, YvonneX <[email protected]>; Jiang, > Cheng1 <[email protected]>; Ding, Xuan <[email protected]> > Subject: [PATCH] vhost: fix unnecessary dirty page logging > > From: Xuan Ding <[email protected]> > > The dirty page logging is only required in vhost enqueue direction for > live migration. This patch removes the unnecessary dirty page logging > in vhost dequeue direction. Otherwise, it will result in a performance > drop. Some if-else judgements are also optimized to improve performance. > > Fixes: 6d823bb302c7 ("vhost: prepare sync for descriptor to mbuf > refactoring") > Fixes: b6eee3e83402 ("vhost: fix sync dequeue offload") > > Signed-off-by: Xuan Ding <[email protected]> > ---
Reviewed-by: Chenbo Xia <[email protected]> Although it's late in release, we can consider to merge this as I see it impacts the performance by 5%: http://inbox.dpdk.org/dev/byapr11mb2711f13cda2b0a4535a6591efe...@byapr11mb2711.namprd11.prod.outlook.com/T/#t But also, it will be good to know the performance issue is solved by sharing the test results. Thanks, Chenbo
