[Public] + sunil
-----Original Message----- From: Akhil Goyal <[email protected]> Sent: Tuesday, August 16, 2022 9:31 PM To: Namburu, Chandu-babu <[email protected]>; [email protected] Cc: [email protected]; David Marchand <[email protected]> Subject: RE: [EXT] Re: [PATCH] crypto/ccp: Check for the NULL pointer after calling rte_malloc Hi, Could you please reply to David and Stephen's comments? Regards, Akhil > On Wed, Jul 20, 2022 at 8:29 AM Namburu, Chandu-babu <[email protected]> > wrote: > > From: Shiqi Liu <[email protected]> > > > > As the possible failure of the rte_malloc(), the not_checked and > > checked could > be NULL pointer. > > Therefore, it should be better to check it in order to avoid the > > dereference of > the NULL pointer. > > > > Fixes: 09a0fd736a0 ("crypto/ccp: enable IOMMU") > > Signed-off-by: Shiqi Liu <[email protected]> > > This sha_ctx variable and its accesses are suspicious. > > It seems to be used as some kind of intermediate buffer, but I fail to > see the need. > Can't the existing code rely on sess->auth.ctx ? > > There is also a suspicious mention (in ccp_perform_sha) of sha_ctx but > with no calling rte_mem_virt2iova(). > > > -- > David Marchand
