> -----Original Message-----
> From: David Marchand <[email protected]>
> Sent: Friday, August 26, 2022 8:42 PM
> To: [email protected]
> Cc: [email protected]; [email protected]; Rosen Xu
> <[email protected]>;
> Gagandeep Singh <[email protected]>; [email protected]; Nicolas Chautru
> <[email protected]>; Ray Kinsella <[email protected]>; Lee Daly
> <[email protected]>;
> Fan Zhang <[email protected]>; Ashish Gupta <[email protected]>;
> Sunila Sahu
> <[email protected]>; Ruifeng Wang <[email protected]>; Ajit Khaparde
> ([email protected]) <[email protected]>; Raveendra
> Padasalagi
> <[email protected]>; Vikas Gupta <[email protected]>;
> Chandubabu
> Namburu <[email protected]>; Pablo de Lara <[email protected]>;
> Michael Shamis
> <[email protected]>; Liron Himi <[email protected]>; Chengwen Feng
> <[email protected]>; Kevin Laatz <[email protected]>; Sachin Saxena
> <[email protected]>; [email protected]; Liang Ma
> <[email protected]>; Peter
> Mccarthy <[email protected]>; Harry van Haaren
> <[email protected]>; John W.
> Linville <[email protected]>; Ciara Loftus <[email protected]>; Qi
> Zhang
> <[email protected]>; Chas Williams <[email protected]>; Min Hu (Connor)
> <[email protected]>; Gaetan Rivet <[email protected]>; Jakub Grajciar
> <[email protected]>;
> Zyta Szpak <[email protected]>; Tetsuya Mukawa <[email protected]>; Harman
> Kalra
> <[email protected]>; Jasvinder Singh <[email protected]>; Cristian
> Dumitrescu
> <[email protected]>; Matan Azrad <[email protected]>; Maxime
> Coquelin
> <[email protected]>; Chenbo Xia <[email protected]>; Jakub Palider
> <[email protected]>; Tomasz Duszynski <[email protected]>; Tianfei
> zhang
> <[email protected]>; Ferruh Yigit <[email protected]>; Andrew
> Rybchenko
> <[email protected]>
> Subject: [PATCH v4 17/27] bus/vdev: make driver-only headers private
>
> The vdev bus interface is for drivers only.
> Mark as internal and move the header in the driver headers list.
>
> While at it, cleanup the code:
> - fix indentation,
> - remove unneeded reference to bus specific singleton object,
> - remove unneeded list head structure type,
> - reorder the definitions and macro manipulating the bus singleton object,
> - remove inclusion of rte_bus.h and fix the code that relied on implicit
> inclusion,
>
> Signed-off-by: David Marchand <[email protected]>
> Acked-by: Rosen Xu <[email protected]>
> ---
> Changes since RFC v2:
> - squashed cleanup for this bus code from other patches,
> - updated release notes,
>
> ---
> app/test/test_vdev.c | 2 +-
> doc/guides/rel_notes/release_22_11.rst | 4 +-
> drivers/baseband/la12xx/bbdev_la12xx.c | 2 +-
> drivers/baseband/null/bbdev_null.c | 2 +-
> .../baseband/turbo_sw/bbdev_turbo_software.c | 2 +-
> drivers/bus/vdev/bus_vdev_driver.h | 151 ++++++++++++++++++
> drivers/bus/vdev/meson.build | 1 +
> drivers/bus/vdev/rte_bus_vdev.h | 134 ----------------
> drivers/bus/vdev/vdev.c | 8 +-
> drivers/bus/vdev/vdev_params.c | 1 -
> drivers/bus/vdev/version.map | 9 +-
> drivers/compress/isal/isal_compress_pmd.c | 2 +-
> drivers/compress/zlib/zlib_pmd.c | 2 +-
> drivers/crypto/armv8/rte_armv8_pmd.c | 2 +-
> drivers/crypto/bcmfs/bcmfs_device.h | 2 +-
> drivers/crypto/caam_jr/caam_jr.c | 2 +-
> drivers/crypto/ccp/rte_ccp_pmd.c | 2 +-
> drivers/crypto/ipsec_mb/ipsec_mb_private.c | 2 +-
> drivers/crypto/ipsec_mb/ipsec_mb_private.h | 2 +-
> drivers/crypto/ipsec_mb/pmd_kasumi.c | 2 +-
> drivers/crypto/mvsam/rte_mrvl_pmd.c | 2 +-
> drivers/crypto/null/null_crypto_pmd.c | 2 +-
> drivers/crypto/openssl/rte_openssl_pmd.c | 2 +-
> drivers/crypto/scheduler/scheduler_pmd.c | 2 +-
> drivers/dma/skeleton/skeleton_dmadev.c | 2 +-
> drivers/event/dpaa2/dpaa2_eventdev.c | 2 +-
> drivers/event/dpaa2/dpaa2_eventdev_selftest.c | 2 +-
> drivers/event/octeontx/ssovf_evdev.c | 2 +-
> drivers/event/octeontx/ssovf_evdev_selftest.c | 2 +-
> drivers/event/opdl/opdl_evdev.c | 2 +-
> drivers/event/opdl/opdl_evdev_init.c | 2 +-
> drivers/event/opdl/opdl_test.c | 2 +-
> drivers/event/skeleton/skeleton_eventdev.c | 2 +-
> drivers/event/sw/sw_evdev.c | 2 +-
> drivers/event/sw/sw_evdev_selftest.c | 2 +-
> drivers/net/af_packet/rte_eth_af_packet.c | 2 +-
> drivers/net/af_xdp/rte_eth_af_xdp.c | 2 +-
> drivers/net/bonding/rte_eth_bond_api.c | 2 +-
> drivers/net/bonding/rte_eth_bond_pmd.c | 2 +-
> drivers/net/failsafe/failsafe.c | 3 +-
> drivers/net/ipn3ke/ipn3ke_ethdev.h | 2 +-
> drivers/net/kni/rte_eth_kni.c | 2 +-
> drivers/net/memif/memif_socket.c | 2 +-
> drivers/net/memif/rte_eth_memif.c | 2 +-
> drivers/net/mvneta/mvneta_ethdev.c | 2 +-
> drivers/net/mvpp2/mrvl_ethdev.c | 2 +-
> drivers/net/null/rte_eth_null.c | 2 +-
> drivers/net/octeontx/octeontx_ethdev.c | 2 +-
> drivers/net/pcap/pcap_ethdev.c | 2 +-
> drivers/net/pfe/pfe_ethdev.c | 2 +-
> drivers/net/ring/rte_eth_ring.c | 2 +-
> drivers/net/softnic/rte_eth_softnic.c | 2 +-
> drivers/net/tap/rte_eth_tap.c | 2 +-
> drivers/net/vdev_netvsc/vdev_netvsc.c | 2 +-
> drivers/net/vhost/rte_eth_vhost.c | 2 +-
> drivers/net/virtio/virtio_user_ethdev.c | 2 +-
> drivers/raw/cnxk_gpio/cnxk_gpio.c | 2 +-
> drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c | 2 +-
> drivers/raw/ifpga/ifpga_rawdev.c | 2 +-
> drivers/raw/skeleton/skeleton_rawdev.c | 2 +-
> drivers/raw/skeleton/skeleton_rawdev_test.c | 2 +-
> lib/ethdev/ethdev_vdev.h | 2 +-
> lib/eventdev/eventdev_pmd_vdev.h | 2 +-
> 63 files changed, 221 insertions(+), 200 deletions(-) create mode 100644
> drivers/bus/vdev/bus_vdev_driver.h
>
> diff --git a/app/test/test_vdev.c b/app/test/test_vdev.c index
> 5eeff3106d..3cc3abe70b
> 100644
> --- a/app/test/test_vdev.c
> +++ b/app/test/test_vdev.c
> @@ -9,7 +9,7 @@
> #include <rte_common.h>
> #include <rte_kvargs.h>
> #include <rte_bus.h>
> -#include <rte_bus_vdev.h>
> +#include <bus_vdev_driver.h>
This line of change is unnecessary? Application uses rte header.
The rest looks good to me.
Reviewed-by: Ruifeng Wang <[email protected]>
