On 9/7/2022 2:48 AM, Long Li wrote:
Subject: Re: [Patch v7 01/18] net/mana: add basic driver, build environment
and doc
On Fri, 2 Sep 2022 18:40:43 -0700
[email protected] wrote:
From: Long Li <[email protected]>
MANA is a PCI device. It uses IB verbs to access hardware through the
kernel RDMA layer. This patch introduces build environment and basic
device probe functions.
Signed-off-by: Long Li <[email protected]>
---
You should add a reference to minimal required version of rdma-core.
Older versions won't work right.
I'm adding a reference to build requirement in doc/guides/nics/mana.rst.
"drivers/net/mana/meson.build" has a build dependency on libmana from
rdma-core. It won't build on older versions of rdma-core.
It is better to add specific version information that has support,
"older/newer" are relative and vague.
