> -----Original Message----- > From: Jerin Jacob <[email protected]> > Sent: Thursday, September 15, 2022 12:12 PM > To: Naga Harish K, S V <[email protected]>; Thomas Monjalon > <[email protected]> > Cc: [email protected]; [email protected]; Carrillo, Erik G > <[email protected]>; [email protected]; > [email protected]; [email protected] > Subject: Re: [PATCH v7 2/3] timer: fix function to stop all timers > > On Wed, Sep 14, 2022 at 9:03 PM Naga Harish K S V > <[email protected]> wrote: > > > > There is a possibility of deadlock in this API, as same spinlock is > > tried to be acquired in nested manner. > > > > If the lcore that is stopping the timer is different from the lcore > > that owns the timer, the timer list lock is acquired in timer_del(), > > even if local_is_locked is true. Because the same lock was already > > acquired in rte_timer_stop_all(), the thread will hang. > > > > This patch removes the acquisition of nested lock. > > > > Fixes: 821c51267bcd63a ("timer: add function to stop all timers in a > > list") > > Cc: [email protected] > > > > Signed-off-by: Naga Harish K S V <[email protected]> Acked-by: Erik Gabriel Carrillo <[email protected]>
Added missing ack > > --- > > lib/timer/rte_timer.c | 13 ++++--------- > > Since this change in lib/timer. Delegating this patch to @Thomas Monjalon
