Acked-by: Kai Ji <[email protected]>
> -----Original Message----- > From: Akhil Goyal <[email protected]> > Sent: Wednesday, September 21, 2022 4:03 PM > To: [email protected] > Cc: [email protected]; [email protected]; > [email protected]; [email protected]; > [email protected]; [email protected]; > [email protected]; [email protected]; > [email protected]; [email protected]; [email protected]; > [email protected]; [email protected]; [email protected]; > [email protected]; [email protected]; > [email protected]; De Lara Guarch, Pablo > <[email protected]>; [email protected]; [email protected]; > Yang, Qiming <[email protected]>; Wu, Wenjun1 > <[email protected]>; [email protected]; Wu, Jingjing > <[email protected]>; Xing, Beilei <[email protected]>; > [email protected]; Akhil Goyal <[email protected]>; Zhang, Roy > Fan <[email protected]> > Subject: [PATCH v2 1/6] cryptodev: rework session framework > > As per current design, rte_cryptodev_sym_session_create() and > rte_cryptodev_sym_session_init() use separate mempool objects > for a single session. > And structure rte_cryptodev_sym_session is not directly used > by the application, it may cause ABI breakage if the structure > is modified in future. > > To address these two issues, the rte_cryptodev_sym_session_create > will take one mempool object that the session and session private > data are virtually/physically contiguous, and initializes both > fields. The API rte_cryptodev_sym_session_init is removed. > > rte_cryptodev_sym_session_create will now return an opaque session > pointer which will be used by the app and other APIs. > > In data path, opaque session pointer is attached to rte_crypto_op > and the PMD can call an internal library API to get the session > private data pointer based on the driver id. > > Note: currently single session may be used by different device > drivers, given it is initialized by them. After the change the > session created by one device driver cannot be used or > reinitialized by another driver. > > Signed-off-by: Akhil Goyal <[email protected]> > Signed-off-by: Fan Zhang <[email protected]> > ---
