> -----Original Message----- > From: Ferruh Yigit <[email protected]> > Sent: Friday, September 2, 2022 01:24 > To: Guo, Junfeng <[email protected]>; Zhang, Qi Z > <[email protected]>; Wu, Jingjing <[email protected]> > Cc: [email protected]; Li, Xiaoyun <[email protected]>; > [email protected]; Richardson, Bruce > <[email protected]> > Subject: Re: [PATCH v2 09/10] net/gve: add stats support > > On 8/29/2022 9:41 AM, Junfeng Guo wrote: > > > > > Update stats add support of dev_ops stats_get/reset. > > > > Signed-off-by: Xiaoyun Li <[email protected]> > > Signed-off-by: Junfeng Guo <[email protected]> > > --- > > drivers/net/gve/gve.h | 10 ++++++ > > drivers/net/gve/gve_ethdev.c | 69 > ++++++++++++++++++++++++++++++++++++ > > drivers/net/gve/gve_rx.c | 15 ++++++-- > > drivers/net/gve/gve_tx.c | 12 +++++++ > > 4 files changed, 104 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/net/gve/gve.h b/drivers/net/gve/gve.h > > index 004e0a75ca..e256a2bec2 100644 > > --- a/drivers/net/gve/gve.h > > +++ b/drivers/net/gve/gve.h > > @@ -91,6 +91,10 @@ struct gve_tx_queue { > > struct gve_queue_page_list *qpl; > > struct gve_tx_iovec *iov_ring; > > > > + /* Stats */ > > + uint64_t packets; > > + uint64_t bytes; > > + > > Can't you get stats for 'errors' in Tx path?
Yes, will add in the coming version. Thanks! >
