RE: [PATCH v3 2/9] net/gve: add logs and OS specific implementation

[Guo, Junfeng]

> -----Original Message-----
> From: Stephen Hemminger <step...@networkplumber.org>
> Sent: Saturday, September 24, 2022 03:01
> To: Guo, Junfeng <junfeng....@intel.com>
> Cc: Zhang, Qi Z <qi.z.zh...@intel.com>; Wu, Jingjing
> <jingjing...@intel.com>; ferruh.yi...@xilinx.com; dev@dpdk.org; Li,
> Xiaoyun <xiaoyun...@intel.com>; awogbem...@google.com; Richardson,
> Bruce <bruce.richard...@intel.com>; Lin, Xueqin <xueqin....@intel.com>;
> Wang, Haiyue <haiyue.w...@intel.com>
> Subject: Re: [PATCH v3 2/9] net/gve: add logs and OS specific
> implementation
> 
> On Fri, 23 Sep 2022 17:38:22 +0800
> Junfeng Guo <junfeng....@intel.com> wrote:
> 
> > +
> > +#define PMD_DRV_LOG(level, fmt, args...) \
> > +   rte_log(RTE_LOG_ ## level, gve_logtype_driver, "%s(): " fmt "\n",
> \
> > +           __func__, ## args)
> 
> Many of your existing log messages already have newline, so using this
> common definition will create double spaced log messages.
> 
> Please audit all usages and print one newline.

Sure, will double check all the usages and update in the coming version.
Thanks!