RE: [PATCH] app/test: fix LACP handshake overtime

[Zhang, Ke1X]

Hi humin:

Thanks for your comments, I test the case, I try to change

for (i = 0; i < 30 && all_slaves_done == 0; ++i)
to
for (i = 0; i < 32 && all_slaves_done == 0; ++i)

it works good, so I think 60 is enough.

And the "conf.update_timeout_ms" seems to be used as a base unit to compute in 
many places as below:

Test_link_bonding_mode4.c (app\test):   return conf.update_timeout_ms;
Test_link_bonding_mode4.c (app\test):   old_delay = conf.update_timeout_ms;
Test_link_bonding_mode4.c (app\test):   conf.update_timeout_ms = 10;
Test_link_bonding_mode4.c (app\test):   for (i = 0; i < 
old_delay/conf.update_timeout_ms * 2; i++) {
Test_link_bonding_mode4.c (app\test):           
rte_delay_ms(conf.update_timeout_ms);
Test_link_bonding_mode4.c (app\test):   for (j = 0; j < 
conf.long_timeout_ms/conf.update_timeout_ms + 2; j++) {
Test_link_bonding_mode4.c (app\test):           
rte_delay_ms(conf.update_timeout_ms);

So I didn't change the value, please confirming , many thanks.

BR
Zhangke

> -----Original Message-----
> From: humin (Q) <humi...@huawei.com>
> Sent: Friday, September 23, 2022 8:58 AM
> To: Zhang, Ke1X <ke1x.zh...@intel.com>; ch...@att.com; dev@dpdk.org
> Cc: sta...@dpdk.org
> Subject: Re: [PATCH] app/test: fix LACP handshake overtime
> 
> Hi, Zhang,
> 
>      Why LACP handshake "overtime" in your test?
> 
>      Maybe in other occasions, 60 * delay is also not enough.
> 
>      BTW, how about config "conf.update_timeout_ms" for the test?
> 
> 在 2022/8/18 13:43, Ke Zhang 写道:
> > Increase the loop count so that there is a longer threshold time for
> > the LACP handshake process.
> >
> > Fixes: 5e41ab250dfa ("app/test: unit tests for bonding mode 4")
> > Cc: sta...@dpdk.org
> >
> > Signed-off-by: Ke Zhang <ke1x.zh...@intel.com>
> > ---
> >   app/test/test_link_bonding_mode4.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/app/test/test_link_bonding_mode4.c
> > b/app/test/test_link_bonding_mode4.c
> > index d9b9c323c7..bfdd18cdd1 100644
> > --- a/app/test/test_link_bonding_mode4.c
> > +++ b/app/test/test_link_bonding_mode4.c
> > @@ -613,7 +613,7 @@ bond_handshake(void)
> >
> >     /* Exchange LACP frames */
> >     all_slaves_done = 0;
> > -   for (i = 0; i < 30 && all_slaves_done == 0; ++i) {
> > +   for (i = 0; i < 60 && all_slaves_done == 0; ++i) {
> >             rte_delay_ms(delay);
> >
> >             all_slaves_done = 1;