> -----Original Message----- > From: David Marchand <[email protected]> > Sent: Tuesday, October 4, 2022 3:14 PM > To: [email protected] > Cc: [email protected]; Jerin Jacob Kollanukkaran <[email protected]>; > [email protected]; Sunil Kumar Kori <[email protected]> > Subject: [EXT] [PATCH v2 3/9] trace: fix leak with regexp > > External Email > > ---------------------------------------------------------------------- > The precompiled buffer initialised in regcomp must be freed before leaving > rte_trace_regexp. > > Fixes: 84c4fae4628f ("trace: implement operation APIs") > Cc: [email protected] > > Signed-off-by: David Marchand <[email protected]> > --- > Changes since v1: > - split patch in two, keeping only the backportable fix as patch 3, > > --- > lib/eal/common/eal_common_trace.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) >
Acked-by: Sunil Kumar Kori <[email protected]> > diff --git a/lib/eal/common/eal_common_trace.c > b/lib/eal/common/eal_common_trace.c > index 1b86f5d2d2..1db11e3e14 100644 > --- a/lib/eal/common/eal_common_trace.c > +++ b/lib/eal/common/eal_common_trace.c > @@ -218,8 +218,10 @@ rte_trace_regexp(const char *regex, bool enable) > rc = rte_trace_point_disable(tp->handle); > found = 1; > } > - if (rc < 0) > - return rc; > + if (rc < 0) { > + found = 0; > + break; > + } > } > regfree(&r); > > -- > 2.37.3
