> -----Original Message----- > From: Jerin Jacob <[email protected]> > Sent: Wednesday, October 12, 2022 10:45 AM > To: Morten Brørup <[email protected]>; Van Haaren, Harry > <[email protected]> > Cc: Jerin Jacob <[email protected]>; [email protected]; Li, WeiyuanX > <[email protected]>; Thomas Monjalon <[email protected]>; Ferruh Yigit > <[email protected]>; Andrew Rybchenko <[email protected]> > Subject: Re: rte_event_dev_xstats_reset id type > > On Wed, Oct 12, 2022 at 1:40 PM Morten Brørup <[email protected]> > wrote: > > > > Hi Jerin (eventdev maintainer), > > + [email protected] as the changes in drivers/event/sw.
Thanks Jerin. > > While looking into bug #1101 [1], I noticed a mix of unsigned int and > > uint32_t in > the test code, which will fail on 64-bit big endian CPUs. Aha; that we can fix. I am curious why this isn't found in CI/reported before. > > Specifically, rte_event_dev_xstats_reset() is called with the "ids" > > parameter > pointing to an unsigned int [2], but that parameter is a pointer to an > uint32_t. > > > > I think the type of the ids array parameter to rte_event_dev_xstats_reset() > > should > be changed to unsigned int array, like in the other rte_event_dev_xxx() > functions. In this case, we have the option to change the type of a variable in a test-case, or change API and cause API/ABI breakage. Lets change the unit test code from "unsigned int" to uint32_t, and that will fix the issue? From a quick review in the test code, there are 3x occurrences of "unsigned int id" being used. I will send a patch to change them later today. > > Or even better, use the same type for an "xstats id" across all device > > types. For > ethdev devices, they are uint64_t, but I don't know why. (They are passed > around as > arrays, so they could be 32 bit. I guess that they were originally not used > in arrays, so > unsigned int seemed the logical choice.) > > > > > > [1]: https://bugs.dpdk.org/show_bug.cgi?id=1101 > > [2]: > > https://git.dpdk.org/dpdk/tree/drivers/event/sw/sw_evdev_selftest.c#n1766 > > > > > > Med venlig hilsen / Kind regards, > > -Morten Brørup
