> -----Original Message-----
> From: Andrew Rybchenko <[email protected]>
> Sent: Monday, October 3, 2022 21:20
> To: Guo, Junfeng <[email protected]>; Zhang, Qi Z
> <[email protected]>; Wu, Jingjing <[email protected]>; Xing,
> Beilei <[email protected]>
> Cc: [email protected]; Wang, Xiao W <[email protected]>
> Subject: Re: [PATCH v2 02/14] net/idpf/base: add logs and OS specific
> implementation
> 
> On 9/5/22 13:58, Junfeng Guo wrote:
> > Add PMD logs.
> > Add some MACRO definations and small functions which are specific
> > for DPDK.
> >
> > Signed-off-by: Beilei Xing <[email protected]>
> > Signed-off-by: Junfeng Guo <[email protected]>
> 
> The patch adds dead code as well. Added headers are used
> nowhere.
> 
> One more question is what's the point to have two things in one
> patch? Typically such descriptions suggest that it could be
> separate patches in a right order.

Sure, will improve this in the coming version patchset. Thanks!

Reply via email to