> -----Original Message-----
> From: Zhou, YidingX <[email protected]>
> Sent: Monday, November 14, 2022 12:31 AM
> To: [email protected]; Yang, Qiming <[email protected]>
> Cc: Zhang, Qi Z <[email protected]>; [email protected]; Zhou,
> YidingX <[email protected]>; [email protected]
> Subject: [PATCH v5] net/iavf: revert fix VLAN insertion
>
> The vector Tx path does not support VLAN insertion via the L2TAG2 field, but
> the scalar path supports. The earlier commit was to force to select scalar
> path as soon as kernel driver requests to use L2TAG2. That logic is incorrect.
> Because other case like VLAN offloading not required but scalar path selected
> would have a significant performance drop.
>
> Therefore the following commit was reverted accordingly.
>
> commit 0d58caa7d6d1 ("net/iavf: fix VLAN insertion")
>
> After reverting this commit, the AVX512 Tx path would insert the VLAN tag
> into the wrong location(inner of QinQ) when the kernel driver requested
> L2TAG2. This is inconsistent with the behavior of PF(outer of QinQ).
>
> It is currently known that ice kernel drivers newer than 1.8.9 will request
> the
> use of L2TAG2. User can set parameter '--force-max-simd-bitwidth' to
> 64/128/256 to avoid this issue.
>
> Fixes: 0d58caa7d6d1 ("net/iavf: fix VLAN insertion")
> Cc: [email protected]
>
> Signed-off-by: Yiding Zhou <[email protected]>
Acked-by: Qi Zhang <[email protected]>
Applied to dpdk-next-net-intel.
Thanks
Qi
