Hi,
> -----Original Message----- > From: Thomas Monjalon <[email protected]> > Sent: 25 January 2023 18:48 > To: Shivah Shankar Shankar Narayan Rao <[email protected]> > Cc: [email protected]; Jerin Jacob Kollanukkaran <[email protected]>; Anup > Prabhu <[email protected]>; Srikanth Yalavarthi > <[email protected]>; [email protected]; > [email protected]; [email protected] > Subject: [EXT] Re: [PATCH v3 0/4] implementation of ML common code > > External Email > > ---------------------------------------------------------------------- > 20/12/2022 18:52, Srikanth Yalavarthi: > > Machine Learning common code > > ---------------------------- > > > > This patch series implements the common ML code that can be used by ML > > drivers. Common code include functions to convert ML IO type to > > string, IO format type to string, function get size of ML IO type, and > > functions for converting data types from higher precision to lower > > precision and vice-versa. > > I'm not sure about the path of this code. > In general we implement drivers helper in the same directory as the driver > and mark it as internal. > Would it work here? We are planning to implement two different ML drivers, ml/cnxk driver (submitted for review) and a software only driver (part of ML roadmap and currently WIP). Both the drivers would be using these common functions for quantization and dequantization. Hence, placed the files in common/ml directory. Moreover, these functions are used to convert data from higher to lower precision or vice-versa and can also be used by future ML drivers for other platforms. > > > drivers/common/meson.build | 1 + > > drivers/common/ml/meson.build | 25 + > > drivers/common/ml/ml_utils.c | 118 ++++ > > drivers/common/ml/ml_utils.h | 283 +++++++++ > > drivers/common/ml/ml_utils_neon.c | 873 > ++++++++++++++++++++++++++++ > > drivers/common/ml/ml_utils_scalar.c | 720 +++++++++++++++++++++++ > > drivers/common/ml/version.map | 25 + > >
