RE: [PATCH v3 5/6] common/idpf: add alarm to support handle vchnl message

[Wu, Jingjing]

> > > +
> > >   new_link.link_duplex = RTE_ETH_LINK_FULL_DUPLEX;
> > > + new_link.link_status = vport->link_up ? RTE_ETH_LINK_UP :
> > > +         RTE_ETH_LINK_DOWN;
> > >   new_link.link_autoneg = !(dev->data->dev_conf.link_speeds &
> > >                             RTE_ETH_LINK_SPEED_FIXED);
> > Better to use RTE_ETH_LINK_[AUTONEG/FIXED] instead.
> >
> [Liu, Mingxia] According to the comment description of struct rte_eth_conf,
> RTE_ETH_LINK_SPEED_FIXED is better.
> struct rte_eth_conf {
> uint32_t link_speeds; /**< bitmap of RTE_ETH_LINK_SPEED_XXX of speeds to be
>                               used. RTE_ETH_LINK_SPEED_FIXED disables link
>                               autonegotiation, and a unique speed shall be
>                               set. Otherwise, the bitmap defines the set of
>                               speeds to be advertised. If the special value
>                               RTE_ETH_LINK_SPEED_AUTONEG (0) is used, all 
> speeds
>                               supported are advertised. */
> 
I am talking about link_autoneg but not link_speeds