Hi, > -----Original Message----- > From: Bing Zhao <[email protected]> > Sent: Monday, July 3, 2023 12:51 PM > To: Matan Azrad <[email protected]>; Slava Ovsiienko > <[email protected]>; Ori Kam <[email protected]>; Suanming Mou > <[email protected]>; Raslan Darawsheh <[email protected]> > Cc: [email protected]; Gregory Etelson <[email protected]>; > [email protected]; David Marchand <[email protected]> > Subject: [PATCH v3] net/mlx5: fix flow workspace destruction > > From: Gregory Etelson <[email protected]> > > PMD uses pthread key to allocate and access per thread flow workspace > memory buffers. > > PMD registered a key destructor function to clean up flow workspace buffers. > However, the key destructor was not called by the pthread library. > > The patch keeps track of per-thread flow workspaces in PMD. > Flow workspaces memory release is activated from PMD destructor. > > In the meanwhile, workspace buffer and RSS queues array are allocated in a > single memory chunk with this patch. The maximal number of queues > RTE_ETH_RSS_RETA_SIZE_512 is chosen. Then the workspace adjustment can > be removed to reduce the software hiccup: > 1. realloc and content copy > 2. spinlock acquire and release > > Bugzilla ID: 1255 > > Fixes: 5d55a494f4e6 ("net/mlx5: split multi-thread flow handling per OS") > Cc: [email protected] > > Reported-by: David Marchand <[email protected]> > Signed-off-by: Gregory Etelson <[email protected]> > Signed-off-by: Bing Zhao <[email protected]> > Acked-by: Matan Azrad <[email protected]> > --- > v2: fix typo and code style > v3: add bugzilla information
Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh
