Sounds good to me Thanks EA
From: David Marchand <[email protected]> Date: Friday, 29 September 2023 at 17:00 To: Elena Agostini <[email protected]> Cc: [email protected] <[email protected]>, Levend Sayar <[email protected]>, Aaron Conole <[email protected]>, [email protected] <[email protected]> Subject: Re: [PATCH] gpu/cuda: fix getenv related build error External email: Use caution opening links or attachments On Thu, Aug 3, 2023 at 6:25 PM Levend Sayar <[email protected]> wrote: > > If gdrapi.h is available, meson sets DRIVERS_GPU_CUDA_GDRCOPY_H as 1. > This causes gdrcopy.c build to give an error; > because compiler can not find signature of getenv. > stdlib.h is included for the definition of getenv function. > There was a bug report for this issue: Bugzilla ID: 1133 > Fixes: ca12f5e8a7db ("gpu/cuda: mark unused GDRCopy functions parameters") It is probably worth backporting: Cc: [email protected] > > Signed-off-by: Levend Sayar <[email protected]> Elena, this is a quick one, review please. -- David Marchand
