Hi, > -----Original Message----- > From: Dariusz Sosnowski <[email protected]> > Sent: Monday, November 20, 2023 10:25 AM > To: Matan Azrad <[email protected]>; Slava Ovsiienko > <[email protected]>; Ori Kam <[email protected]>; Suanming Mou > <[email protected]> > Cc: [email protected]; Raslan Darawsheh <[email protected]>; > [email protected] > Subject: [PATCH] net/mlx5: fix offset field size in conntrack action > > In mlx5 PMD, struct mlx5_aso_ct_action represents a single ASO CT object > inside a ASO CT bulk, which is used to implement conntrack flow action. > offset field, which is 16 bits wide, in this struct represents > an offset of the given object inside a bulk. > > When SW Steering flow engine is used, ASO CT bulks are allocated on > demand, each having 64 objects. In this case offset field can fit any > valid object offset. > > When HW Steering flow engine is used, a single ASO CT bulk is allocated > during flow engine configuration. Since HW supports bulks bigger > than 2^16 this offset field is too small to fit all valid values. > This causes some ASO CT objects to be incorrectly reused on multiple > connections, when more than 2^16 conntrack flow actions are used. > > This patch fixes this behavior. offset field size is increased > to 32 bits. > > Fixes: 463170a7c934 ("net/mlx5: support connection tracking with HWS") > Cc: [email protected] > Cc: [email protected] > > Signed-off-by: Dariusz Sosnowski <[email protected]> > Acked-by: Ori Kam <[email protected]>
Patch applied to next-net-mlx, Kindest regards Raslan Darawsheh
