Hi, > -----Original Message----- > From: Bing Zhao <[email protected]> > Sent: Thursday, March 7, 2024 10:09 AM > To: Slava Ovsiienko <[email protected]>; [email protected]; Raslan > Darawsheh <[email protected]> > Cc: Ori Kam <[email protected]>; Dariusz Sosnowski > <[email protected]>; Suanming Mou <[email protected]>; > Matan Azrad <[email protected]>; Michael Baum <[email protected]>; > [email protected] > Subject: [PATCH] net/mlx5: fix age position in hairpin split > > When splitting a hairpin rule implicitly, the count action will be on either > Tx or > Rx subflow based on the encapsulation checking. > > Once there is a flow rule with both count and age action, one counter will be > reused. If there is only age action and the ASO flow hit is supported, the > flow > hit will be chosen instead of a counter. > > In the previous flow splitting, the age would always be in the Rx part, while > the > count would be on the Tx part when there is an encap. > > Before this commit, 2 issues can be observed with a hairpin split: > 1. On the root table, one counter was used on both Rx and Tx parts > for age and count actions. Then one ingress packet will be > counted twice. > 2. On the non-root table, an extra ASO flow hit was used on the Rx > part. This would cause some overhead. > > The age and count actions should be in the same subflow instead of 2. > > Fixes: daed4b6e3db2 ("net/mlx5: use aging by counter when counter exists") > Cc: [email protected] > Cc: [email protected] > > Signed-off-by: Bing Zhao <[email protected]> > Acked-by: Ori Kam <[email protected]> Patch applied to next-net-mlx,
Kindest regards Raslan Darawsheh

