On Wed, May 28, 2025 at 1:27 AM Andre Muezerie <[email protected]> wrote: > > With gcc, the macro __rte_used translates to __attribute__((used)). > MSVC has something to the same effect, but harder to use and with some > limitations (one being that it cannot be used with "static"). Therefore, > it makes sense to avoid __rte_used in some cases. > > The functions modified in this patch don't really need to use __rte_used. > Instead, these functions can be involved in same ifdefs used in the > callers. That way, they are only defined when needed (when > someone is actually calling the function). Doing so makes the code > compatible with MSVC and avoids compiler warnings about functions being > defined but not used. > > Signed-off-by: Andre Muezerie <[email protected]> > Acked-by: Pavan Nikhilesh <[email protected]> > ---
> > -static __rte_used inline void > +#if defined(RTE_ARCH_ARM64) > +#if !defined(CNXK_DIS_TMPLT_FUNC) Please change to #if defined(RTE_ARCH_ARM64) && !defined(CNXK_DIS_TMPLT_FUNC) in all instances.
