Hi Stephen,

We have exported the API and are currently testing it using our internal 
application. This feature is specific to our platform.

The existing ethdev queue rate_limit API supports per-queue rate limiting. 
However, our use case requires per-port rate limiting, so we have implemented a 
custom solution to support this functionality.

Regards,
Vanshika

> -----Original Message-----
> From: Stephen Hemminger <[email protected]>
> Sent: 29 June 2025 22:13
> To: Vanshika Shukla <[email protected]>
> Cc: [email protected]; Thomas Monjalon <[email protected]>; Hemant
> Agrawal <[email protected]>; Sachin Saxena
> <[email protected]>; Vinod Pullabhatla
> <[email protected]>
> Subject: [EXT] Re: [v4 07/10] net/dpaa: add Tx rate limiting DPAA PMD API
> 
> Caution: This is an external email. Please take care when clicking links or
> opening attachments. When in doubt, report the message using the 'Report
> this email' button
> 
> 
> On Wed, 11 Jun 2025 12:40:36 +0530
> [email protected] wrote:
> 
> > From: Vinod Pullabhatla <[email protected]>
> >
> > Add support to set Tx rate on DPAA platform through PMD APIs
> >
> > Signed-off-by: Vinod Pullabhatla <[email protected]>
> > Signed-off-by: Vanshika Shukla <[email protected]>
> > ---
> 
> You intended to add a PMD specific API for rate limiting.
> But there is no RTE_EXPORT_SYMBOL so it was never used.
> 
> You would have found this if you added a test for it.
> 
> Not accepting this without a test in test-pmd for it.
> 
> And why is the existing ethdev queue rate_limit not a better API here?

Reply via email to