RE: [PATCH v3 01/17] net/txgbe: support flow filter for VF

[Jiawen Wu]

> -----Original Message-----
> From: Stephen Hemminger <step...@networkplumber.org>
> Sent: Tuesday, July 1, 2025 10:39 PM
> To: Jiawen Wu <jiawe...@trustnetic.com>
> Cc: dev@dpdk.org; zaiyuw...@trustnetic.com
> Subject: Re: [PATCH v3 01/17] net/txgbe: support flow filter for VF
> 
> On Fri, 13 Jun 2025 16:41:43 +0800
> Jiawen Wu <jiawe...@trustnetic.com> wrote:
> 
> > +bool txgbe_is_pf(struct txgbe_hw *hw)
> > +{
> > +   switch (hw->mac.type) {
> > +   case txgbe_mac_raptor:
> > +           return true;
> > +   default:
> > +           return false;
> > +   }
> > +}
> > +
> 
> This is ok as is, but you could make it much simpler as:
> 
> bool txgbe_is_pf(const struct txgbe_hw *hw)
> {
>       return hw->mac.type == txgbe_mac_raptor;
> }
> 
> Or are you planning for future hardware?

Yes. Other mac types will be added soon.