Re: Re: [PATCH v4 04/14] net/sxe: add link, flow ctrl, mac ops, mtu ops function

[刘洁]

> -----原始邮件-----
&gt; 发件人: "Stephen Hemminger" <step...@networkplumber.org>
&gt; 发送时间: 2025-07-10 00:09:30 (星期四)
&gt; 收件人: "Jie Liu" <liuj...@linkdatatechnology.com>
&gt; 抄送: dev@dpdk.org
&gt; 主题: Re: [PATCH v4 04/14] net/sxe: add link, flow ctrl, mac ops, mtu ops 
function
&gt; 
&gt; On Wed,  9 Jul 2025 04:43:04 -0400
&gt; Jie Liu <liuj...@linkdatatechnology.com> wrote:
&gt; 
&gt; &gt; +     RTE_ATOMIC(bool)link_thread_running;
&gt; &gt; +     RTE_ATOMIC(bool)is_stopping;
&gt; 
&gt; Despite what checkpatch says, need space here:
&gt;    RTE_ATOMIC(bool) is_stopping;
&gt; 
&gt; &gt; +     rte_thread_t link_thread_tid;
&gt; &gt; +     rte_atomic32_t link_thread_running;
&gt; 
&gt; Don't use old rte atomics, instead use RTE_ATOMIC() consistently
&gt; 
&gt; &gt; +     rte_atomic32_t is_stopping;
&gt; &gt; +     pthread_t link_thread_tid;
&gt; 
&gt; Two struct elements with same name, how does that work?
&gt; 
&gt; &gt; +     bool is_stopped;

This will be fully revised in the 14th patch, so please don't 
worry.</liuj...@linkdatatechnology.com></liuj...@linkdatatechnology.com></step...@networkplumber.org>