Hello, On Sat, 30 Aug 2025 at 02:23, Andre Muezerie <[email protected]> wrote: > > On Fri, Aug 29, 2025 at 03:04:10PM +0200, David Marchand wrote: > > Hello, > > > > On Tue, 5 Aug 2025 at 22:00, Andre Muezerie > > <[email protected]> wrote: > > > > > > This patch fixes some issues which were preventing this test to be > > > built on Windows: > > > > > > - Remove VLAs (not supported by msvc). > > > - Replace strsep() (which is not natively available on Windows) > > > with strtok_r(). > > > - Remove the "thousands" separator from printf() calls as it is > > > not available on Windows. > > > > Can we use rte_size_to_str() instead? > > > > I considered doing that, but I thought that since the app is printing deltas > it > could be better to print the exact numbers instead of some approximation like > "1.02 k" which could possibly make debugging harder. > > If you strongly believe that rte_size_to_str() should indeed be used here I > can > make the change. > > What are your thoughts about this?
No strong opinion: just that we introduced this rte_size_to_str() for this "thousands" separator stuff. I don't mind merging as is, and I did not hear from Wisam, so I guess this is fine. -- David Marchand
