Okay, I initially thought this was common practice across all architectures, but it turns out only x86 added #include "rte_cpuflags.h" here. I’ve now moved it to lib/fib/dir24_8_rvv.h and updated v3.
> -----原始邮件----- > 发件人: "Thomas Monjalon" <[email protected]> > 发送时间: 2025-09-19 23:13:19 (星期五) > 收件人: "Sun Yuechi" <[email protected]> > 抄送: [email protected], "Stanislaw Kardach" <[email protected]>, [email protected] > 主题: Re: [PATCH v2 2/5] eal/riscv/spinlock: add rte_cpuflag.h > > 01/07/2025 20:20, [email protected]: > > From: Sun Yuechi <[email protected]> > > > > Same as the x86 style, include "rte_cpuflags.h" in rte_spinlock.h > > so that files like lib/fib/dir24_8.c don’t need to include it. > > > > Signed-off-by: Sun Yuechi <[email protected]> > > I disagree. > I prefer removing useless includes like in x86 spinlock. > </[email protected]></[email protected]></[email protected]></[email protected]></[email protected]>
