cgivre commented on code in PR #2558: URL: https://github.com/apache/drill/pull/2558#discussion_r882962178
########## docs/dev/PluginCredentialsProvider.md: ########## @@ -118,7 +121,7 @@ Once it is set, we can configure storage plugin to use this way of obtaining cre } ``` -`secretPath` property specifies the Vault key value from which to read +`secretPath` property specifies the Vault key value from which to read. If the plugin's `authMode` is set to `user_translation` then the `secretPath` may include a variable named `$user` which will be replaced with the Drill query username at query execution time. Review Comment: NIT/Question: If `user_translation` mode is enabled, isn't it a requirement that the `secretPath` contain `$user`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
