jnturton commented on code in PR #2565:
URL: https://github.com/apache/drill/pull/2565#discussion_r885206059
##########
pom.xml:
##########
@@ -3988,13 +3988,13 @@
<jdk>[9,)</jdk>
</activation>
<properties>
+ <maven.compiler.release>8</maven.compiler.release>
<junit.args>
--add-opens=java.base/java.lang=ALL-UNNAMED
--add-opens java.base/java.net=ALL-UNNAMED
--add-opens java.base/java.nio=ALL-UNNAMED
--add-opens=java.base/java.util=ALL-UNNAMED
--add-opens java.base/sun.nio.ch=ALL-UNNAMED
- --add-opens java.security.jgss/sun.security.krb5=ALL-UNNAMED
Review Comment:
@vvysotskyi the module opening lines here are only arguments passed to
JUnit, so do you think that if all the unit tests are happy when running in JDK
17 then we are covered here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
