Leif Mortenson wrote:
Vadim,
Thanks for your patch. Looking over it, it looks like the output stream would still not be
closed in the case where there were not any errors.
Yup, forgot one line :)
I committed a modified patch to SVN as well as went through and added javadocs to
the relevant interfaces making it more obvious that these streams need to be closed by the
calling code. Could you take a look at the changes and post back if you see any problems.
There are couple of issues... You are loosing original IOException in lines 520, 533, 539:
520: modDestination.cancel( out );
533: out.close();
539: in.close();
If an IOException has been thrown already, any new IOException which can happen in these lines will cause original IOException to get lost.
Worst case scenario, you are loosing 3 IOExceptions and showing only the very last, fourth one. My gut feeling tells me the very first one usually way more informative than the fourth one.
I guess, ideally, you would preserve original exception in all glory, and add messages from all of the following exceptions if you don't want to ignore them:
message += "and on top of that, you've got " + e;
As for the build, we are using Maven now rather than Ant. The Maven build is working
fine on my system. What version of Maven are you using? and what is the failure you are
seeing?
To build the whole tree, cd into the Excalibur root and run:
maven multiproject:install
I was soo naive. I was trying simply "maven" from excalibur, and from excalibur/components/sourceresolve directories.
Now, it fails with:
BUILD FAILED
File...... file:/.../.maven/plugins/maven-multiproject-plugin-1.1/
Element... maven:reactor
Line...... 174
Column.... 9
The build cannot continue because of the following unsatisfied dependencies:
mailapi-1.3.1.jar (no download url specified) jms-1.1.jar (no download url specified)
It's maven-1.0-rc1.
Thanks, Vadim
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] Apache Excalibur Project -- URL: http://excalibur.apache.org/
