Jorg Heymans wrote:
Carsten,

Are these fixes intented to correct the broken sourceresolver behaviour we saw in Cocoon ? If yes then i would suggest i cut another release of this.

Yes, as noone came up with a testcase, I'm now trying to find the problem/fix by testing 2.1.x with the latest source resolver code.

It seems that the problem is much worse than we imagined. I just found out that our fix which corrects the url on macos has the problem that it now creates a url which the jdk on macos can't understand anymore. So the jdk seems to know the bug and expects this behaviour.

Here is a snippet from Cocoon's directory generator:
            String systemId = this.directorySource.getURI();
            if (!systemId.startsWith(FILE)) {
throw new ResourceNotFoundException(systemId + " does not denote a directory");
            }
            // This relies on systemId being of the form "file://..."
            File directoryFile = new File(new URL(systemId).getFile());
            if (!directoryFile.isDirectory()) {
throw new ResourceNotFoundException(super.source + " is not a directory.");
            }

With the correct 2.2.2 version, the last test fails as the file does not point to the correct resource on the file system anymore. If we don't fix the url and let getURI() return the wrong uri (with only one slash), everything else works again.

So, it seems that we should remove the url fix again and rely on the buggy implementation.

WDYT?

Carsten

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to