Marcel Offermans wrote:
> Hello Carsten,
> 
> Unfortunately, due to a DNS failure, I cannot currently access the felix
> website (infra seems to be aware of this), but I think the cleanup of
> the imports you did, did a bit more than just that. It prepended "this."
> in a lot of places, such as the one I quoted below:
> 
>>      public PsCommandImpl(BundleContext context)
>>      {
>> -        m_context = context;
>> +        this.m_context = context;
>>      }
> 
> That does not match with our code conventions on the site. We use "m_"
> so we don't need to prefix things with "this.". The question that now
> arises is, do we actively want to reformat the whole codebase according
> to our conventions? If so, I think we should discuss that first. For now
> I think it would be best to at least fix those "this." lines that have
> been introduced while organizing the imports.
> 
Argh, sure - yes I'll do that - I thought that I had turned off my
Eclipse save actions for Felix, it appears I haven't. Sorry for that!

Carsten
-- 
Carsten Ziegeler
[EMAIL PROTECTED]

Reply via email to