[
https://issues.apache.org/jira/browse/FELIX-338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12519995
]
Richard S. Hall commented on FELIX-338:
---------------------------------------
The LDAP package is self-contained. I don't think it is a good idea to move
LDAP code outside the LDAP package, nor is it a good idea to duplicate that
code elsewhere, since code duplication is a maintenance headache. Perhaps it
would be possible to modify Evaluator.evaluate() method to accept both the
program and the mapper so that it can be re-entrant?
> Framework FilterImpl is not thread safe on execution
> ----------------------------------------------------
>
> Key: FELIX-338
> URL: https://issues.apache.org/jira/browse/FELIX-338
> Project: Felix
> Issue Type: Bug
> Components: Framework
> Affects Versions: 0.8.0, 1.0.0
> Reporter: Felix Meschberger
> Attachments: filter.patch, FilterImpl_rewrite.patch
>
>
> Executing a Filter implemented by the Felix Framework FilterImpl class is not
> thread safe, as the Filter.Implmatch() methods are not synchronized but use a
> Mapper and Evaluator instance fields which are modified while matching the
> filter.
> Two options seem to exist:
> 1. Make the match() methods synchronized
> 2. Create Mapper and Evaluator instances on each match() call
> My assumption is that the second method tends to be better because of the
> synchronization needed with the first approach.
> Reported by Tom Remoleur, thanks. The full mail thread leading to this issue
> may be found at [1].
> [1] http://www.mail-archive.com/[EMAIL PROTECTED]/msg00145.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
