[
https://issues.apache.org/jira/browse/FELIX-1789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12788149#action_12788149
]
Guillaume Nodet commented on FELIX-1789:
----------------------------------------
I've spotted one slight problem which can lead to a NPE if I understand the
patch correctly.
In the Utils file, the patch looks the following:
{code}
@@ -216,11 +240,15 @@
{
return true;
}
- public void log(boolean debug, String message, Throwable throwable)
+
+ public void log(int logLevel, int msgLevel, String message, Throwable
throwable)
{
- System.out.println(message + (throwable == null ? "" : ": " +
throwable));
- if (debug && throwable != null)
+ // Only print the message if logging is enabled and
+ // the message level is less than or equal to the log
+ // level.
+ if ((logLevel > 0) && (msgLevel <= logLevel))
{
+ System.out.println(message + (throwable == null ? "" : ": " +
throwable));
throwable.printStackTrace(System.out);
}
}
{code}
if {{throwable}} is {{null}}, this should lead to a NPE which was prevented
with the test in the current code.
The remaining of the patch looks good to me.
> FileInstall is too verbose
> --------------------------
>
> Key: FELIX-1789
> URL: https://issues.apache.org/jira/browse/FELIX-1789
> Project: Felix
> Issue Type: Bug
> Components: File Install
> Affects Versions: fileinstall-2.0.0
> Environment: generic
> Reporter: Sahoo
> Fix For: fileinstall-2.0.6
>
> Attachments: FELIX-1789.txt
>
>
> GlassFish users have commented that FileInstall is too verbose. They suggest
> the initial configuration related messages to be moved to debug level.
> e.g.,
> INFO: {felix.fileinstall.poll (ms) = 5000, felix.fileinstall.dir =
> /space/ss141213/WS/gf/v3/publish/glassfishv3/glassfish/domains/domain1/autodeploy/bundles,
> felix.fileinstall.debug = 1, felix.fileinstall.bundles.new.start = true,
> felix.fileinstall.tmpdir = /tmp/fileinstall, felix.fileinstall.filter = null}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
