bosschaert commented on pull request #84: URL: https://github.com/apache/felix-dev/pull/84#issuecomment-891664672
Hi @bdelacretaz thanks for the changes. I'm fine with the changes to the README but I think the unit tests for the StandaloneInterpolator should remain in the same package as the implementation of it. This is a commonly accepted unit test pattern (some references here https://softwareengineering.stackexchange.com/questions/328780/naming-convention-for-test-packages and here https://stackoverflow.com/questions/2388253/separation-of-junit-classes-into-special-test-package ). If you'd like to test that the StandaloneInterpolator can also be used from a different package I think this should be a _new_ test (rather than moving the existing test). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
