[ http://issues.apache.org/jira/browse/GERONIMO-2324?page=comments#action_12428410 ] David Jencks commented on GERONIMO-2324: ----------------------------------------
I'm not thoroughly convinced this is a good idea. Does tomcat offer a similar feature? Some of my concerns: - Can you get the same effect by changing the classes and libs properties of the existing gbean? - Why would we encourage people to use shared lib rather than explicit dependencies? I'd rather see the repo code modified to include links to the actual jar/exploded jar location so you could point bits of the repo into your development environment. - What is the value of writing out an empty externals file? I think if you don't supply a file, we should assume you are not interested in this feature and not modify the environment. Certainly if no externals file name is supplied, we shouldn't try to write a file. - Does this actually work for both classes directories and individual jars? A test would be nice. On a technical level, the e.printStackTrace should be replaced with a log statement. In general there look to be a lot of failure cases that aren't taken care of. If an externals file is listed and not present, it's possible we should fail startup. > Allow in-place and exploded jar support for sharedlib > ----------------------------------------------------- > > Key: GERONIMO-2324 > URL: http://issues.apache.org/jira/browse/GERONIMO-2324 > Project: Geronimo > Issue Type: RTC > Security Level: public(Regular issues) > Components: deployment > Affects Versions: 1.1 > Reporter: Sachin Patel > Assigned To: Sachin Patel > Fix For: 1.x > > Attachments: GERONIMO-2324.patch > > > The shared library support should allow in-place support to allow and load > jars (exploded as well) that are located externally on the filesystem. This > is needed to improve developer experience and allow better integration within > tooling and the runtime. > Perhaps we can have a properties file insie the shared lib that have external > entries in them. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
