[
http://issues.apache.org/jira/browse/GERONIMO-2332?page=comments#action_12429261
]
John Sisson commented on GERONIMO-2332:
---------------------------------------
Agree with Alan's objection that it should be placed elsewhere.
I tested applying it to 1.1.1 and openejb/branches/v2_1_1/openejb2 and did a
build. I had to manually apply the changes to openejb's etc/project.properties
due to a conflict with the geronimo_dependency_plugin_version that is two lines
above the change.
Assuming Alan's argument is addressed *and* the new schema jar is fixed to
contain LICENSE.txt and NOTICE.txt files under META-INF, *then I'm +1*.
One other minor point is that if one builds the schema jar with just the
{{mvn}} command instead of {{mvn -o clean install -Pgenerate-source}} they will
get a BUILD SUCCESSFUL but the JAR won't contain any classes. The only other
hint of a problem is that there is the line {{[WARNING] JAR will be empty - no
content was marked for inclusion!}}. Is there something we can do to fail the
build?
> RTC Put the generated xmlbeans files for the j2ee 1.4 schemas in svn in a
> spec module so we don't need the schemas in svn at all
> --------------------------------------------------------------------------------------------------------------------------------
>
> Key: GERONIMO-2332
> URL: http://issues.apache.org/jira/browse/GERONIMO-2332
> Project: Geronimo
> Issue Type: RTC
> Security Level: public(Regular issues)
> Components: specs
> Affects Versions: 1.2, 1.1.1, 1.1.2
> Reporter: David Jencks
> Assigned To: David Jencks
> Fix For: 1.2, 1.1.1, 1.1.2
>
> Attachments: GERONIMO-2332-1.1.patch,
> GERONIMO-2332-openejb-2.1.patch, GERONIMO-2332-trunk.patch,
> geronimo-schema_1.4_spec-generated-src.zip, geronimo-schema_1.4_spec-src.zip
>
>
> See GERONIMO-2307. It seems that the option with the least legal exposure is
> to not distribute and sun schema files and not have any in our svn. This is
> a proposed spec module that uses a m2 profile to pull the schemas from suns
> website (where they are freely available), run xmlbeans on them, and remove
> the copies of the schemas that xmlbeasn helpfully tries to include in the
> output. We can then check this stuff into svn.
> A normal non-profile build then just builds these sources into a jar. We can
> replace the xmlbeans step in j2ee-schema with a geronimo dependency on this
> new spec jar.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
