[ http://issues.apache.org/jira/browse/GERONIMO-2380?page=comments#action_12433473 ] Paul McMahan commented on GERONIMO-2380: ----------------------------------------
Vamsi, some comments on the patch. Create Private Key portlet: "Number of days valid" is checked for being numerical but not for emptiness. If left empty the portlet throws a NumberFormatException. Also, the popup messages prompt for the form's internal variable names instead of the display name. Upload certificate portlet: The Trusted Cerficate field is not empty by default. It contains the text "...paste trusted certificate text here...". So checking the field for emptiness is not very useful. > Keystores portlet - Form field validation using javascript > ---------------------------------------------------------- > > Key: GERONIMO-2380 > URL: http://issues.apache.org/jira/browse/GERONIMO-2380 > Project: Geronimo > Issue Type: Improvement > Security Level: public(Regular issues) > Components: console > Affects Versions: 1.1.1 > Environment: Win XP, G 1.1.1-rc1 > Reporter: Vamsavardhana Reddy > Fix For: 1.1.2, 1.1.x, 1.2 > > Attachments: GERONIMO-2380.patch > > > Forms in Keystores portlet could use field validation using javascript to > check for empty strings and non numerical values before posting the data to > the server. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
